D24761: Asign correct column width when importing XLS file
Damien Caliste
noreply at phabricator.kde.org
Mon Oct 28 13:36:01 GMT 2019
dcaliste added a comment.
Well, after reading the difference between the logical and physical DPI values: https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt (see the first answer), using the logical value is consistent with the hard coded "arial 10" font metric some line above.
Maybe adding a comment near the modified line explaining that logicalDPI should be used because of the "Arial 10" font metric being nice also on high DPI screen would be nice. If not too much burden…
Good catch @davidllewellynjones !
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24761
To: davidllewellynjones, #calligra:_3.0, pvuorela
Cc: dcaliste, davidllewellynjones, Calligra-Devel-list, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191028/d9c54ff4/attachment.htm>
More information about the calligra-devel
mailing list