D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

[Pekka Vuorela]

pvuorela added a comment.


  A bit mixed feelings for this. In a way nice to avoid unnecessary work, but then again it seems effectively a compilation option if xlsx support is for read-write or view-only. On main level CMake it's also a bit random detail compared to others.
  
  Could be nice to have this sort of things as some kind of hints to file opening api, but not spotting any existing mechanism.

INLINE COMMENTS

> XlsxXmlWorksheetReader.cpp:1603
>      int sharedGroupIndex = -1;
> -    if (t == QLatin1String("shared")) {
> +    if ((!t.isEmpty()) && (t == QLatin1String("shared"))) {
>          TRY_READ_ATTR(si)

Doesn't latter already imply non-empty?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25008

To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste
Cc: anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191121/22dd1fe5/attachment.htm>