D25033: Extract images from excel files which omit the FtCF entry.

Pekka Vuorela noreply at phabricator.kde.org
Thu Nov 7 09:48:09 GMT 2019


pvuorela accepted this revision.
pvuorela added a comment.
This revision is now accepted and ready to land.


  Minor comment, but overall looks good to me.

INLINE COMMENTS

> excel.cpp:1421
> +        if (ft2 == 0x0008) {
> +            Q_ASSERT(ft2 == 0x0008); Q_UNUSED(ft2);
> +            const unsigned long cb2 = readU16(startPict + 2);

Minor, but this line can be removed now?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25033

To: denexter, pvuorela
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191107/93bebeb3/attachment.htm>


More information about the calligra-devel mailing list