D19884: Avoid deprecated QAbstractItemModel::reset()

[Damien Caliste]

dcaliste added inline comments.

INLINE COMMENTS

> TextDocumentStructureModel.cpp:308
>  
> -    reset();
>  }

I did the same changes in https://phabricator.kde.org/D15102 at another place and I put the begin and end at the start and end of the routine, like you did. But I remember that I got review asking not to risk to change signal order emission, in case, and put the begin/end just around the m_textDocument assignment.

I'm not completely sure that I remember correctly and I cannot find it in Phabricator anymore...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela
Cc: dcaliste, Calligra-Devel-list, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190319/6c854a9f/attachment.htm>