D18466: Fixed calligra crashing when opening remote document

Niccolò Venerandi noreply at phabricator.kde.org
Wed Jan 30 09:56:15 GMT 2019


niccolove added a comment.


  What have I Done:
  
  - Added slots in KoApplication to manage pdf and print. Cancel is already KoMainWindow::slotLoadCanceled with an error popup, what should a KoApplication::slotLoadCanceled do?
  - Added connection for pdf print and moved it before document opening (local files works)
  - I added the KoMainView to the loadCompleted signal, as a new one might be created in KoMainWindow::slotLoadCompleted, and the slots needs the new one to call slotFilePrint or exportToPdf.
  - Filename is passed to slot using a lambda, like specified on the slots and signals qt documentation
  
  Things seem working. Should I do anything else?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190130/6cf5a176/attachment.htm>


More information about the calligra-devel mailing list