D18866: Use check_symbol_exists instead of check_function_exists
Heiko Becker
noreply at phabricator.kde.org
Fri Feb 8 21:39:56 GMT 2019
heikobecker created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
heikobecker requested review of this revision.
REVISION SUMMARY
check_function_exists has some shortcomings, which fails to detect
isnan when build against musl libc. The cmake documentation [1]
suggests to prefer check_symbol_exists, which detects isnan/isinf
fine on both glibc and musl.
[1] https://cmake.org/cmake/help/latest/module/CheckFunctionExists.html#command:check_function_exists
TEST PLAN
Builds with glibc and musl
REPOSITORY
R8 Calligra
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18866
AFFECTED FILES
filters/words/msword-odf/wv2/CMakeLists.txt
To: heikobecker
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190208/03840e58/attachment.htm>
More information about the calligra-devel
mailing list