D23327: [Gemini] Clarify deletion of document

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Calligra: 3.0, boemann, danders.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  When you open Gemini in desktop and close the document view became empty (maybe noCleanUp should protected against) however you have no options except to close the window which crash since root document is dangling pointer (crash in isLoading() with invalid this pointer). I try to reload a document but instead touch view should be activated?

TEST PLAN
  1. Open a document in Gemini (another issue is templates has a protocol templates:// which is not handled any, i guess it was in framework)
  2. Switch to desktop view
  3. File -> close
  
  Another issue is when you try to switch on desktop mode but there is no document loaded.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D23327

AFFECTED FILES
  gemini/MainWindow.cpp
  libs/main/KoMainWindow.cpp
  libs/main/KoPart.cpp

To: anthonyfieroni, #calligra:_3.0, boemann, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190821/9041568c/attachment.htm>