D23202: Fix headers for >=KCalCore-5.12.0

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> icalendarexport.cpp:30
>  
> +#if KCALCORE_VERSION >= QT_VERSION_CHECK(5, 12, 0)
> +#include <kcalendarcore/attendee.h>

You can't test for the version number before including kcal[endar]core_version.h ... catch 22.

This is going to need a cmake check for which header is available.

Or kcalendarcore could keep installing a kcalcore_version.h file with the same contents as kcalendarcore_version.h?

But then I also wonder if one day kcalendarcore_version.h will define KCALENDARCORE_VERSION rather than KCALCORE_VERSION... sounds like it should do both then...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D23202

To: asturmlechner, #calligra:_3.0, dfaure, vkrause
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190816/fd76ca75/attachment.htm>