D15775: Make the item background color and page cache properties available from View component

Damien Caliste noreply at phabricator.kde.org
Wed Sep 26 16:00:07 BST 2018


dcaliste created this revision.
dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Currently, the item background color and the page cache properties in Words are built-in values (_resp. _ set to QColor(232, 233, 234) and false). They cannot be changed from QML or at all (for the background color). Users of libCalligraComponents.so and friends must patch the sources to change their behaviours.
  
  This PR introduces a method to set the background color in KWCanvasItem. It also expands Components::View by overloading the fillColor property of QQuickPaintedItem and adds a pageCacheEnabled(bool) property.
  
  The two new properties are implemented for text documents and are irrelevant for the other kind of document (but may have some sense in the future, if needed).
  
  Is it the right way to go?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

AFFECTED FILES
  components/Document.cpp
  components/Document.h
  components/View.cpp
  components/View.h
  components/impl/DocumentImpl.cpp
  components/impl/DocumentImpl.h
  components/impl/TextDocumentImpl.cpp
  components/impl/TextDocumentImpl.h
  words/part/KWCanvasBase.cpp
  words/part/KWCanvasBase.h
  words/part/KWCanvasItem.cpp
  words/part/KWCanvasItem.h

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180926/e30f8248/attachment.html>


More information about the calligra-devel mailing list