D15679: Add missing dependencies for PART_STAGE

Damien Caliste noreply at phabricator.kde.org
Fri Sep 21 14:52:36 BST 2018


dcaliste created this revision.
dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Currently, KPrNotes is using the text shape and the picture shape in its creator method (see line 67 and line 78). As a consequence, in a presentation, when creating a new page in KPrDocument.cpp#171, the page creation itself is creating a KPrNotes (see KPrPage.cpp#56) and finally if one of the two shape plugins is not compiled, the Q_ASSERT() will catch the non existing shape, at best, or if compiled with QT_NO_DEBUG, the program will crash.
  
  As PART_WORD is depending on PLUGIN_TEXTSHAPE, I'm modifying the depency tree to add PLUGIN_TEXTSHAPE and PLUGIN_PICTURESHAPE for PART_STAGE.
  
  Compiling then plugins/pictureshape, I took the opportunity to update two function calls in QMouseEvent.
  
  Maybe it would be nice to replace the Q_ASSERT with an if (factory) {} and put a warning in the else part in case of a wrong installation and plugins are missing. What do you think ?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15679

AFFECTED FILES
  CalligraProducts.cmake
  plugins/pictureshape/CropWidget.cpp

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180921/8cd03cd6/attachment.html>


More information about the calligra-devel mailing list