D15236: Add missing dependencies in CMakeLists.txt

Damien Caliste noreply at phabricator.kde.org
Mon Sep 3 11:10:29 BST 2018


dcaliste created this revision.
dcaliste added reviewers: leinir, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Add missing dependencies in target_link_libraries() cmake macro here and there. Added dependencies comes from #include<> directives for specific headers, like for instance having #include<kmessagebox.h> but not specifying KF5::WidgetsAddons.
  
  I'm still a bit puzzled know how it can compile without these modifications since required '-I path' compiler options are then missing… Maybe because I'm using non standard pathes for compilation.
  
  Additionally, I've moved the add_includedirs() macro in sheets/CMakeLists.txt inside the ifdef PART_SHEETS, otherwise the eigen3 include directory variable may not be set, when configuring without part_sheets and cmake fails in that case.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15236

AFFECTED FILES
  libs/flake/CMakeLists.txt
  libs/main/CMakeLists.txt
  libs/odf/CMakeLists.txt
  libs/store/CMakeLists.txt
  libs/widgets/CMakeLists.txt
  plugins/textshape/CMakeLists.txt
  sheets/CMakeLists.txt
  sheets/shape/CMakeLists.txt
  stage/part/CMakeLists.txt
  words/part/CMakeLists.txt

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180903/d1767f2a/attachment.html>


More information about the calligra-devel mailing list