D15053: Consistently use qreal in libs/pigment

Damien Caliste noreply at phabricator.kde.org
Mon Sep 3 09:14:32 BST 2018


dcaliste updated this revision to Diff 40892.
dcaliste added a comment.


  Update the patch not to use the form ```qBound(qreal(0.0), a, qreal(1.0))``` but ```qBound<qreal>(0.0, a, 1.0)``` instead. For reference, original form was ```qBound(0.0, a, 1.0)``` which was causing issues when qreal <-> float, because of mixed doubles and floats.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15053?vs=40358&id=40892

REVISION DETAIL
  https://phabricator.kde.org/D15053

AFFECTED FILES
  libs/pigment/KoColorConversions.cpp
  libs/pigment/KoColorSpace.cpp
  libs/pigment/KoColorSpace.h
  libs/pigment/KoColorSpaceAbstract.h
  libs/pigment/KoColorSpaceTraits.h
  libs/pigment/colorprofiles/KoDummyColorProfile.cpp
  libs/pigment/colorprofiles/KoDummyColorProfile.h
  libs/pigment/colorspaces/KoAlphaColorSpace.h
  libs/pigment/colorspaces/KoLabColorSpace.cpp
  libs/pigment/colorspaces/KoLabColorSpace.h
  libs/pigment/colorspaces/KoRgbU16ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU16ColorSpace.h
  libs/pigment/colorspaces/KoRgbU8ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU8ColorSpace.h
  libs/pigment/colorspaces/KoSimpleColorSpace.h

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180903/9f828511/attachment.html>


More information about the calligra-devel mailing list