D16406: Fix build with poppler<0.64
Albert Astals Cid
noreply at phabricator.kde.org
Fri Oct 26 23:29:48 BST 2018
aacid accepted this revision.
aacid added a comment.
When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 <https://phabricator.kde.org/D16406> (i.e. this very same patch) or the compilation error because of the overrides?
The fact that the 3.1 branch "compiles" with the new poppler is just that, "it compiles", but it doesn't really work since the signature of the function it is supposed to reimplement has changed.
So we need "all the fixes" in "all the branches".
But sure, i guess let's commit this and then figure out what to do, not sure with the rest, at least this is a step forward :)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16406
To: arojas, #calligra:_3.0, aacid, pino
Cc: rjvbb, pino, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181026/6e1674e5/attachment.htm>
More information about the calligra-devel
mailing list