D16406: Fix build with poppler<0.64

René J.V. Bertin noreply at phabricator.kde.org
Thu Oct 25 22:19:34 BST 2018


rjvbb added a comment.


  How about
  
    if (Poppler_VERSION VERSION_LESS "0.64.0")
        add_definitions("-DHAVE_POPPLER_PRE_0_64")
  
  That also removes the ambiguity while reading the code ("is this 0.64.0 and higher or only that specific version?") and *may* make it easier to clean obsolete code later on when support for Poppler < 0.64.0 is dropped.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16406

To: arojas, #calligra:_3.0, aacid, pino
Cc: rjvbb, pino, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181025/51cf8669/attachment.htm>


More information about the calligra-devel mailing list