D16367: EnhancedPathShape: Shape is moved/resized on save/load

Dag Andersen noreply at phabricator.kde.org
Mon Oct 22 09:05:33 BST 2018


danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Remove all code that uses viewbox to affect position and size.
  
  Oasis spec:
  The svg:viewBox attribute establishes a user coordinate system inside the coordinate system
  of the shape specified by the position and size attributes.
  
  I interpret this to mean that viewbox shall *never* affect the shapes position or size.

TEST PLAN
  To reproduce: Add a database stencil in flow and save/load.

REPOSITORY
  R8 Calligra

BRANCH
  enhancedpath_danders

REVISION DETAIL
  https://phabricator.kde.org/D16367

AFFECTED FILES
  plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
  plugins/pathshapes/enhancedpath/EnhancedPathShape.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181022/265c4531/attachment.htm>


More information about the calligra-devel mailing list