D15775: Make the item background color and page cache properties available from View component

[Anthony Fieroni]

anthonyfieroni added a comment.


  Also can  you add parentheses over single line code and if you know better way to get impl() without duplicate calls will be great :)

INLINE COMMENTS

> View.cpp:160
>          canvas->setGeometry(0, 0, q->width(), q->height());
> +        static_cast<DocumentImpl*>(document->impl())->setBackgroundColor(q->fillColor());
> +        static_cast<DocumentImpl*>(document->impl())->setPageCache(m_cache);

You don't check against impl is not nullptr?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181004/7f3b4589/attachment.htm>