D16721: Use Krita toolbar in Karbon

Anthony Fieroni noreply at phabricator.kde.org
Thu Nov 8 08:55:06 GMT 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> KoKineticScroller.cpp:28
> +{
> +    KConfigGroup config = KSharedConfig::openConfig()->group("");
> +    int sensitivity = config.readEntry("KineticScrollingSensitivity", 75);

Let's have some name, KoKineticScroller or something. I also notice that you never save option, are they user configurable? It's used always default ones.

> KoKineticScroller.cpp:92
> +{
> +    KConfigGroup config = KSharedConfig::openConfig()->group("");
> +    int gesture = config.readEntry("KineticScrollingGesture", 0);

Same name here.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181108/f2d03e9d/attachment.htm>


More information about the calligra-devel mailing list