D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  I like what you have done - you seem to understand the concepts, so please commit when you feel  like it's working

INLINE COMMENTS

> TestBlockLayout.cpp:333
>      //qDebug() << blockLayout->lineAt(0).y();
> -    QVERIFY(qAbs(blockLayout->lineAt(0).y() - (0.8*12 + 28.0-12.0 + 100.0)) < ROUNDING);
> +    QEXPECT_FAIL("", "FIXME: Should not this calculate with lineheight and not fontsize?", Continue);
> +    QVERIFY2(qAbs(blockLayout->lineAt(0).y() - line2_y) < ROUNDING, QString("Actual: %1 Expected: %2").arg(blockLayout->lineAt(0).y()).arg(line2_y).toLatin1());

yes I think so

REPOSITORY
  R8 Calligra

BRANCH
  blocklayout_unittest_danders

REVISION DETAIL
  https://phabricator.kde.org/D14901

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180831/5ab3e2d5/attachment.htm>