Review Request 130196: Add a seed parameter to make the qHash used
Camilla Boemann
cbr at boemann.dk
Sat Jul 22 20:59:03 BST 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130196/#review103464
-----------------------------------------------------------
Ship it!
Ship It!
- Camilla Boemann
On July 22, 2017, 7:50 p.m., Jos van den Oever wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130196/
> -----------------------------------------------------------
>
> (Updated July 22, 2017, 7:50 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Without the seed parameter, the default qHash for QPair is used.
> The seed argument in qHash was introduced in Qt 5.0. The qHash for
> KoXmlStringPair did not have it and hence it was an unused function.
>
>
> Diffs
> -----
>
> libs/store/KoXmlReader.cpp 4c7f434
>
> Diff: https://git.reviewboard.kde.org/r/130196/diff/
>
>
> Testing
> -------
>
> All unit tests in kostore still pass.
>
>
> Thanks,
>
> Jos van den Oever
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20170722/93c104f6/attachment.htm>
More information about the calligra-devel
mailing list