Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

[René J.V. Bertin]

> On Jan. 11, 2017, 4:37 p.m., Anthony Fieroni wrote:
> > karbon/CMakeLists.txt, line 55
> > <https://git.reviewboard.kde.org/r/129804/diff/1/?file=488919#file488919line55>
> >
> >     Why only for Apple, it's needed some other changes ?

You're right, I made that change yesterday and decided later that I could just as well pretend SVG support also already works on MS Windows. Like this it will as soon as `ecm_add_app_icon` can handle SVG files on MS Windows.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129804/#review101937
-----------------------------------------------------------


On Jan. 11, 2017, 4:30 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129804/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2017, 4:30 p.m.)
> 
> 
> Review request for Calligra and KDE Software on Mac OS X.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Hinted at in my previous RR: this patch concern the generation of app icons on Mac and potentially on MS Windows.
> 
> Several points:
> 
> - The `iconutils` utility is limited or incorrectly invoked by `ecm_add_app_icon`, leading to errors on OS X 10.9 when using PNG files larger than 256x256px . 
> - `ecm_add_app_icon` takes care of copying the icon (.icns) file into the app bundle; no need to install it explicitly
> - a recent change I committed to the ECM allows `ecm_add_app_icon` to accept an SVG (or SVGz) file, and will create the app icon using that file if the `ksvg2icns` utility is available (provided by KIconThemes so it should always be available).
> 
> I hope that this modification will be released with ECM 5.30.0 . The ECM being what they are there should be no issue requiring its latest version, but the changes in the present patch will be transparent with older ECM versions (except for warnings about ignoring unsupported icon source files).
> 
> There is an equivalent `svg2ico` utility in the KDEWin project which also provides a `png2ico` implementation. I plan to propose an updated version for inclusion with KIconThemes. That would allow feature parity for `ecm_add_app_icon` on MSWin, but I would need someone else to test it (I don't have a MSWin dev system).
> 
> 
> Diffs
> -----
> 
>   braindump/src/CMakeLists.txt 95e0772 
>   flow/part/CMakeLists.txt f5d0893 
>   gemini/CMakeLists.txt c8713d6 
>   karbon/CMakeLists.txt ba775ad 
>   plan/CMakeLists.txt 25427da 
>   sheets/CMakeLists.txt 0256de5 
>   stage/app/CMakeLists.txt b5b4464 
>   words/app/CMakeLists.txt 8cf0157 
> 
> Diff: https://git.reviewboard.kde.org/r/129804/diff/
> 
> 
> Testing
> -------
> 
> tested on Mac and Linux with Qt 5.7.1 and FWs 5.29.0 , currently only for Karbon and Words.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20170111/41972ab4/attachment.htm>