Review Request 129782: [calligra] Buildsystem improvements
Camilla Boemann
cbr at boemann.dk
Fri Jan 6 23:18:46 GMT 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129782/#review101845
-----------------------------------------------------------
Ship it!
Ship It!
- Camilla Boemann
On Jan. 6, 2017, 10:58 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129782/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 10:58 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> 3 commits:
>
> - Make Activities and KF5Html really optional.
> Before, trying to use CMAKE_DISABLE_FIND_PACKAGE_KF5{Activities,KHtml} errored out with:
> "if given arguments: "VERSION_LESS" "5.16.0" Unknown arguments specified"
>
> - Fix dependencies, sort and clean trailing whitespaces:
> Add missing KF5JobWidgets
> Drop unused KF5TextEditor
>
> - Push KF5Threadweaver dep to the only place where it is used
>
>
> Diffs
> -----
>
> CMakeLists.txt 3779c9abeff3642ac867c497a2eef637276f8835
> libs/widgets/tests/CMakeLists.txt 39346304bb2c95ce12fea528998a512ab42d19cb
>
> Diff: https://git.reviewboard.kde.org/r/129782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20170106/3207f6e0/attachment.htm>
More information about the calligra-devel
mailing list