[krita] plugins/flake/textshape/kotext/styles: Fix memory leak

Boudewijn Rempt boud at valdyas.org
Tue Sep 13 08:22:56 BST 2016


Git commit fbd916d2af9cc025f505117fd1da13a29e6e3030 by Boudewijn Rempt.
Committed on 13/09/2016 at 07:22.
Pushed by rempt into branch 'master'.

Fix memory leak

==10207== 424 (24 direct, 400 indirect) bytes in 1 blocks are definitely lost in loss record 11,215 of 12,325
==10207==    at 0x4C29670: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10207==    by 0x321A1982: KoStyleManager::KoStyleManager(QObject*) (KoStyleManager.cpp:152)
==10207==    by 0x31B41D3F: TextShapeFactory::newDocumentResourceManager(KoDocumentResourceManager*) const (TextShapeFactory.cpp:158)
==10207==    by 0x6D70D3F: KoShapeBasedDocumentBase::KoShapeBasedDocumentBase() (KoShapeBasedDocumentBase.cpp:40)
==10207==    by 0x50FB291: KisShapeController::KisShapeController(KisDocument*, KisNameServer*) (kis_shape_controller.cpp:71)
==10207==    by 0x5344AD8: KisDocument::init() (KisDocument.cpp:591)
==10207==    by 0x534B5CC: KisDocument::KisDocument() (KisDocument.cpp:527)
==10207==    by 0x538013A: KisPart::createDocument() const (KisPart.cpp:197)
==10207==    by 0x5293D47: KisCustomImageWidget::createNewImage() (kis_custom_image_widget.cc:273)
==10207==    by 0x529503E: KisCustomImageWidget::createImage() (kis_custom_image_widget.cc:232)
==10207==    by 0xC344390: QMetaObject::activate(QObject*, int, int, void**) (in /home/boud/dev/deps/lib/libQt5Core.so.5.6.1)
==10207==    by 0xB2A6551: QAbstractButton::clicked(bool) (in /home/boud/dev/deps/lib/libQt5Widgets.so.5.6.1)
==10207==
==10207== 430 (24 direct, 406 indirect) bytes in 1 blocks are definitely lost in loss record 11,216 of 12,325
==10207==    at 0x4C29670: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10207==    by 0x321A1960: KoStyleManager::KoStyleManager(QObject*) (KoStyleManager.cpp:151)
==10207==    by 0x31B41D3F: TextShapeFactory::newDocumentResourceManager(KoDocumentResourceManager*) const (TextShapeFactory.cpp:158)
==10207==    by 0x6D70D3F: KoShapeBasedDocumentBase::KoShapeBasedDocumentBase() (KoShapeBasedDocumentBase.cpp:40)
==10207==    by 0x50FB291: KisShapeController::KisShapeController(KisDocument*, KisNameServer*) (kis_shape_controller.cpp:71)
==10207==    by 0x5344AD8: KisDocument::init() (KisDocument.cpp:591)
==10207==    by 0x534B5CC: KisDocument::KisDocument() (KisDocument.cpp:527)
==10207==    by 0x538013A: KisPart::createDocument() const (KisPart.cpp:197)
==10207==    by 0x5293D47: KisCustomImageWidget::createNewImage() (kis_custom_image_widget.cc:273)
==10207==    by 0x529503E: KisCustomImageWidget::createImage() (kis_custom_image_widget.cc:232)
==10207==    by 0xC344390: QMetaObject::activate(QObject*, int, int, void**) (in /home/boud/dev/deps/lib/libQt5Core.so.5.6.1)
==10207==    by 0xB2A6551: QAbstractButton::clicked(bool) (in /home/boud/dev/deps/lib/libQt5Widgets.so.5.6.1)
==10207==

Probably also present in Calligra

CCMAIL:calligra-devel at kde.org

M  +2    -0    plugins/flake/textshape/kotext/styles/KoStyleManager.cpp

http://commits.kde.org/krita/fbd916d2af9cc025f505117fd1da13a29e6e3030

diff --git a/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp b/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
index 4dc0cbb..9544133 100644
--- a/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
+++ b/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
@@ -187,6 +187,8 @@ KoStyleManager::KoStyleManager(QObject *parent)
 
 KoStyleManager::~KoStyleManager()
 {
+    delete d->footNotesConfiguration;
+    delete d->endNotesConfiguration;
     delete d;
 }
 



More information about the calligra-devel mailing list