Review Request 129532: [shortcuts] Undo / Redo shortkeys
Camilla Boemann
cbr at boemann.dk
Tue Nov 22 20:10:04 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129532/#review101058
-----------------------------------------------------------
libs/main/KoView.cpp (line 342)
<https://git.reviewboard.kde.org/r/129532/#comment67757>
hmm we shouldn't hardcode these key combinations
- Camilla Boemann
On Nov. 22, 2016, 7:27 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129532/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2016, 7:27 p.m.)
>
>
> Review request for Calligra and Camilla Boemann.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> + fullscreen action provide warning on runtime "Use actionCollection->setDefaultShortcut instead of QAction->setShortcut
>
>
> Diffs
> -----
>
> libs/main/KoMainWindow.cpp 828d789
> libs/main/KoView.cpp f3b6fd9
>
> Diff: https://git.reviewboard.kde.org/r/129532/diff/
>
>
> Testing
> -------
>
> Build and run with Karbon
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20161122/c853ded4/attachment.htm>
More information about the calligra-devel
mailing list