Review Request 122153: KD Chart
Stephen Leibowitz
LibreStephen at gmail.com
Fri Jan 29 19:29:13 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122153/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 7:29 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra and Jarosław Staniek.
Changes
-------
Submitted with commit 07ec84d8ef5c588937bc451a1e675cff924d8585 by Friedrich W. H. Kossebau to branch calligra/2.9.
Repository: calligra
Description
-------
These patches are also being made at kdab.com. Those who have a KDAB account can see the discussion in “Suggested Changes to KD Chart” at
https://quality.kdab.com/browse/KDCH-1020
Calligra’s kdchart and kdgantt files are out-of-date, even with the patches from the above paragraph. For example, “Compiler warnings” at
http://mail.kde.org/pipermail/calligra-devel/2015-January/012762.html
mentioned an error in KDChartPieDiagram.cpp. But the error is in a private function that was removed from the latest version (2.5.1) of KD Chart. KDAB will not patch previous versions. See “PieDiagram::drawPieSurface” at
https://quality.kdab.com/browse/KDCH-1023
KDAB makes available source code for the latest and earlier versions of its KD Chart and other GPL licensed software at http://docs.kdab.com/
Diffs
-----
3rdparty/kdchart/src/KDChartLayoutItems.cpp 095d2cd
3rdparty/kdchart/src/KDChartStockDiagram_p.cpp d8636d7
Diff: https://git.reviewboard.kde.org/r/122153/diff/
Testing
-------
Thanks,
Stephen Leibowitz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20160129/396d5156/attachment.htm>
More information about the calligra-devel
mailing list