Consistent naming of folders in libs/ & renaming kundo2 -> koundo
Friedrich W. H. Kossebau
kossebau at kde.org
Mon Jan 11 17:03:24 GMT 2016
Am Samstag, 9. Januar 2016, 00:11:12 schrieb Jaroslaw Staniek:
> On 8 January 2016 at 23:29, Camilla Boemann <cbo at boemann.dk> wrote:
> > Yeah regarding library names the renaming should rather be the other way
> >
> > I don't want that ko everywhere
>
> Same feeling here. Consistency is good but what I detest while using
> bash or IDE (Creator) completion and most if not all folders have
> names with the same prefix. The purpose of such a prefix is unclear then.
> Especially that these are all local libs. So yes, I'd go the other
> way, in particular kundo2 -> undo.
Using just basenames was also my initial idea. But disadvantages:
a) unbalanced naming of folders:
libs with generic basename (main, text) vs. special named (flake, pigment).
b) results in another alias for the libname ones has to have in mind
(local source files also have full name of class defined in it,
not prefixless, so perhaps a pattern to pick up)
c) generic basenames (main, text) can be mixed up with generic resource folder
names (pics, templates, styles, data), using the full lib name would be
more clear
Like prefixes with class names never have annoyed me when using completion,
also prefixes of folder names have not really done that, So not a real
disadvantage on my list.
But if those two chars are a big bugger for you, I have no strong opinion
here, fine to rename instead the other to prefixless if more people prefer
that?
> > And regarding kundo2 - wasn't it supposed to be a clone of the qt5 so we
> > could get rid of our own version ?
> I am interested in this too since kexi.git forked kundo2 to reduce
> deps. I'd like to know if Qt 5 has all we need or if kundo stays, if
> we can have it in a separate repo. It's 1.5K SLOC. If so I am
> volunteering for making it a repo.
>From what was said and what I saw it seems KUndo2 turned into quite some
variant of its own, coupled with the special calligra_xgettext.
While I am not too keen about splitting more repos off, also due to extra work
on releasing, if that helps to reduce code duplication it might be a good
thing to do afterall.
But what namespace to use for the lib and its repo? KoUndo? KUndo?
Needs someone to analyze what is so special about this undo system, so it
could be reflected in the name. Possibly KoUndo would be best for now, keeping
it a private shared lib of Calligra, not yet maintained for public
consumption, only in own repo for reuse needs between Calligra apps in split
repos.
So not touching kundo2 subfolder for now.
Cheers
Friedrich
More information about the calligra-devel
mailing list