[Differential] [Updated] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

[danders (Dag Andersen)]

danders marked 4 inline comments as done.
danders added a comment.


  Fixed some of your comments, I'll wait for more before updating.

INLINE COMMENTS

> staniek wrote in KoResourcePaths.cpp:43
> Can we drop the "ko" legacy here?
> 
> Or even: do we really need a category per class/namespace or per lib?

I did it to be able to filter out all other debug statements, and I can see where it originates so I find it much easier to use.

> staniek wrote in KoResourcePaths.h:122
> is -> are ?

I see wildcards as a funtion here, hence is.
But I may be very wrong...

> staniek wrote in KoResourcePaths.h:143
> What does the \s mean? Perhaps you meant /s ?

He, he. seems somebody got into trouble.
If you use / you'll get */ which end the comment.
Rewrote the comment to avoid it.

REPOSITORY
  rCALLIGRA Calligra

REVISION DETAIL
  https://phabricator.kde.org/D2577

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: danders, Calligra-Devel-list, #calligra:_3.0, staniek
Cc: staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20160829/6555531f/attachment.htm>