[Differential] [Updated] D362: Modularity++: Move find_package() to places where they belong, make other optional

rempt (Boudewijn Rempt) noreply at phabricator.kde.org
Fri Sep 18 08:06:10 BST 2015


rempt added a comment.

I would prefer to have as many checks in the toplevel cmakelists.txt as possible, actually, because we often end up having a check in two places if we don't. I think that this change would be best applied to a kexi-exit branch, where you can prepare for creating the separate repo by doing bigger refactorings.

For me, if this would land, I probably would have to restore the checks when preparing krita's exit branch. But then, that's going to need a bigger refactoring of the build system in any case.


REPOSITORY
  rCALLIGRA Calligra

REVISION DETAIL
  https://phabricator.kde.org/D362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, kossebau, rempt
Cc: Calligra-Devel-list, wicik, staniek



More information about the calligra-devel mailing list