[Differential] [Requested Changes To] D362: Modularity++: Move find_package() to places where they belong, make other optional

[kossebau (Friedrich W. H. Kossebau)]

kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.

Hm, moving checking for required packages into the subdirs and thus after calculating which products can be built or, if internal dep, should be built breaks the concept of the current productset system. So for now I would like to veto this patch.

So let's see what you actually want to fix here. I see at least 2 problems where I agree that they should be handled:

- external deps is checked for even if none of the products that are built need it
- when explicitely requesting build of a certain app (e.g. by PRODUCTSET=kexi) a missing required external dep does not make the configuration fail, other than expected

Are these also your concerns? Any other? If so, I have something sketched in the back of my mind I could brush up and then propose as alternative and integrated solution.


REPOSITORY
  rCALLIGRA Calligra

REVISION DETAIL
  https://phabricator.kde.org/D362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, rempt, kossebau
Cc: Calligra-Devel-list, wicik, staniek