[Differential] [Request, 301 lines] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek (Jarosław Staniek) noreply at phabricator.kde.org
Thu Sep 17 19:06:33 BST 2015


staniek created this revision.
staniek added a reviewer: rempt.
staniek added a subscriber: Calligra-Devel-list.

REVISION SUMMARY
  It's the same code performance-wise

TEST PLAN
  build

REPOSITORY
  rCALLIGRA Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D361

AFFECTED FILES
  krita/image/kis_cross_device_color_picker.h
  krita/image/kis_fixed_paint_device.cpp
  krita/image/kis_fixed_paint_device.h
  krita/image/kis_group_layer.cc
  krita/image/kis_image.cc
  krita/image/kis_layer.cc
  krita/image/kis_mask.cc
  krita/image/kis_paint_device.cc
  krita/image/kis_paint_device.h
  krita/image/kis_painter.cc
  krita/image/kis_selection_based_layer.cpp
  krita/image/tests/kis_colorspace_convert_visitor_test.cpp
  krita/image/tests/kis_image_test.cpp
  krita/image/tests/kis_selection_test.cpp
  krita/libbrush/kis_gbr_brush.cpp
  krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp
  krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp
  krita/plugins/extensions/dockers/lut/tests/kis_ocio_display_filter_test.cpp
  krita/plugins/extensions/gmic/kis_gmic_simple_convertor.cpp
  krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp
  krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp
  krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp
  krita/plugins/formats/bmp/kis_bmp_export.cpp
  krita/plugins/formats/jpeg/kis_jpeg_converter.cc
  krita/plugins/formats/ppm/kis_ppm_export.cpp
  krita/plugins/formats/tga/kis_tga_export.cpp
  krita/plugins/formats/tiff/kis_tiff_converter.cc
  krita/plugins/tools/tool_transform2/kis_tool_transform.cc
  krita/ui/canvas/kis_display_color_converter.cpp
  krita/ui/canvas/kis_image_pyramid.cpp
  krita/ui/kis_clipboard.cc
  krita/ui/kis_custom_pattern.cc
  krita/ui/kis_mimedata.cpp
  krita/ui/kis_png_converter.cpp
  krita/ui/tests/kis_prescaled_projection_test.cpp
  krita/ui/widgets/kis_scratch_pad.cpp
  libs/pigment/KoColor.cpp
  libs/pigment/KoColorConversionSystem.cpp
  libs/pigment/KoColorConversionTransformation.cpp
  libs/pigment/KoColorConversionTransformation.h
  libs/pigment/KoColorSpace.cpp
  libs/pigment/KoCopyColorConversionTransformation.cpp
  libs/pigment/KoFallBackColorTransformation.cpp
  libs/pigment/KoScaleColorConversionTransformation.h
  libs/pigment/colorspaces/KoSimpleColorSpace.h
  libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp
  plugins/colorengines/lcms2/LcmsColorSpace.h
  plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, rempt
Cc: Calligra-Devel-list



More information about the calligra-devel mailing list