Review Request 125485: Unselect text when the text tool is deactivated.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/
-----------------------------------------------------------

(Updated Oct. 3, 2015, 9:56 a.m.)


Review request for Calligra and Thorsten Zachmann.


Changes
-------

Added screenshot. Steps to reproduce: select text in a text box, then click on the "Shape Handling Tool" tab, then click on another text shape.

Indeed if I start editing in that second text shape the selection in the first one disappears. It just looks quite odd to be in this situation where text is selected even though I'm not editing that box anymore. I admit that nothing really bad happens from there (it doesn't actually show as selected if I start the presentation), but it just looks buggy. And indeed I can even switch slides and come back, and this piece of text is still selected.

But maybe the fix isn't the one I'm providing here.


Repository: calligra


Description
-------

Otherwise text remains selected in Stage after switching to another
shape, which is very unexpected.


Diffs
-----

  plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc 

Diff: https://git.reviewboard.kde.org/r/125485/diff/


Testing
-------


File Attachments (updated)
----------------

text-selection-bug.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/d7bcacc1-e0c0-4021-9055-aa2b77f39a71__text-selection-bug.png


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/241d1eaa/attachment.htm>