Review Request 125485: Unselect text when the text tool is deactivated.

[Camilla Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review86281
-----------------------------------------------------------


This change would go against a lot of special code that ensures the selection stays so I would not like this to go in - what i am not getting is why this is a problem - when the textshape is no longer selected the text is not either - so can you please explain a bit more - if I get it right the problem is more that the textshape stays selected when the slide is changed

- Camilla Boemann


On Oct. 2, 2015, 8:53 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125485/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 8:53 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Otherwise text remains selected in Stage after switching to another
> shape, which is very unexpected.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc 
> 
> Diff: https://git.reviewboard.kde.org/r/125485/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/cbbd8883/attachment.htm>