Review Request 125489: Cleanup KActionMenu usage: activated() is never emitted, member var not needed.

[David Faure]

> On Oct. 3, 2015, 4:29 a.m., Thorsten Zachmann wrote:
> > The patch breaks starting of the Presentation by pressing the Start Presentation button without extending the submenu.

Ah, in the toolbar!! I only tested that in the menus. I see. OK, will discard this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125489/#review86274
-----------------------------------------------------------


On Oct. 2, 2015, 9:09 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125489/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:09 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Cleanup KActionMenu usage: activated() is never emitted, member var not needed.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrView.h 1ca41cee7fc38cc2a3156fad1f2283eaf217e2ef 
>   stage/part/KPrView.cpp 432bc5e023f41a8927cbe9e854b2205962ae4e4b 
> 
> Diff: https://git.reviewboard.kde.org/r/125489/diff/
> 
> 
> Testing
> -------
> 
> No GUI changes seen, the start presentation actions still work
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/138a0e31/attachment.htm>