Review Request 125488: Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125488/#review86273
-----------------------------------------------------------

Ship it!


Ship It!

- Thorsten Zachmann


On Oct. 2, 2015, 9:07 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125488/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> (gdb) p m_imageRect
> $3 = {
>   xp = 139,
>   yp = 0,
>   w = 0,
>   h = 0
> }
> (gdb) p m_selectionRect.m_rect.w
> $6 = -nan(0x8000000000000)
> 
> painter.drawRect() line 103 leads to
> ASSERT: "width > 0.0" in file painting/qrasterizer.cpp, line 757
> 
> 
> Diffs
> -----
> 
>   plugins/pictureshape/CropWidget.cpp 7068c37923daa00c9b51349ae19dd73bb40d982f 
> 
> Diff: https://git.reviewboard.kde.org/r/125488/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/757e4263/attachment.htm>