Review Request 125492: Remove AnimationTmpData struct, take two pointers for output values instead.

Thorsten Zachmann t.zachmann at zagge.de
Sat Oct 3 04:52:56 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125492/#review86270
-----------------------------------------------------------

Ship it!


Patch looks good. Please commit. Thanks for the patch. Boudewijn can you please forward port the patch.

- Thorsten Zachmann


On Oct. 2, 2015, 9:16 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125492/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:16 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This makes the calling code much less confusing to read, and allows
> to get rid of the intermediary overload.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrShapeAnimations.h c00af6df1fc94e69b4924877aa76de52ac750e1c 
>   stage/part/KPrShapeAnimations.cpp a7e51724f1abec256842832bf961679cba4cc7b5 
> 
> Diff: https://git.reviewboard.kde.org/r/125492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/018ea9e0/attachment.htm>


More information about the calligra-devel mailing list