Review Request 125495: Fix empty animation steps when removing animations.

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125495/#review86268
-----------------------------------------------------------

Ship it!


Looks good please commit. Thanks for the patch. Boudewijn can you please port forward.

- Thorsten Zachmann


On Oct. 2, 2015, 9:25 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125495/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:25 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> steps() returns m_shapeAnimations but a (shallow) copy of it.
> So steps().removeAll(step) really doesn't do anything.
> => replace steps() with m_shapeAnimations everywhere.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrShapeAnimations.cpp a7e51724f1abec256842832bf961679cba4cc7b5 
> 
> Diff: https://git.reviewboard.kde.org/r/125495/diff/
> 
> 
> Testing
> -------
> 
> When you had
> 1. <ANIM1>
> 2. <ANIM2>
> in the list of shape animations and then removed ANIM1, the list model would correctly update to
> 1. <ANIM2>
> 
> but then during the presentation, the first click would do nothing, and I would have to click again to see the shapes shown by anim2.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/c5e3e1bb/attachment.htm>