Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.
David Faure
faure at kde.org
Fri Oct 2 22:17:42 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125493/
-----------------------------------------------------------
Review request for Calligra.
Repository: calligra
Description
-------
Mistyping a filename in the file widget would lead to the job failing silently
and the rest of the code trying to load an empty bytearray as the image data.
Better show a msgbox on error and delete the shape.
But this is last resort (e.g. remote URL and lost internet during transfer),
see next commit.
Diffs
-----
plugins/pictureshape/PictureShapeConfigWidget.h 14b59aaf749b335a3f69b075a8422732664f0ecb
plugins/pictureshape/PictureShapeConfigWidget.cpp e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0
Diff: https://git.reviewboard.kde.org/r/125493/diff/
Testing
-------
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151002/c7416615/attachment.htm>
More information about the calligra-devel
mailing list