Many fixes for Stage

[Boudewijn Rempt]

On Fri, 2 Oct 2015, David Faure wrote:

> I used Stage to make a presentation yesterday, and I have many bugfixes
> to submit (and then some questions, and some bug reports).
>
> I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial ones?
> Reviewboard? Phabricator? Patch on ML? Just push, there's nobody to review them anyway?

That's for zagge to say... But once pushed, I'll take care of forward
porting to master. I've done that for your trivial changes as well. At
this point, I'm cherry-picking from 2.9 to master because there's stuff
in 2.9 that shouldn't go in master (some easter eggs...)
>
> * 5454835 - Fix empty animation steps when removing animations.
> * ddc2159 - PictureShapeConfigWidget: ensure we only select existing files.
> * a3edc77 - PictureShapeConfigWidget: add error handling to KIO::Job.
> * 019145d - Remove AnimationTmpData struct, take two pointers for output values instead.
> * f1775d8 - Fix crash when exiting Stage and the presentation mode is still on
> * a446d5c - Make Esc stop the presentation also in the main view.
> * d7569bf - Cleanup KActionMenu usage: activated() is never emitted, member var not needed.
> * 242c772 - Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.
> * b690f72 - Color set dialog: make combo non-editable, since typing a random name serves no purpose there.
> * c733029 - Fix crash when typing a bogus color-set name in the color set dialog.
> * c061c8c - Unselect text when the text tool is deactivated

Impressive set -- that should make 2.9.8 a lot better! 2.9.8 is to be
released next week, btw.

> In addition: why did this commit to calligra/2.8 was never merged to calligra/2.9?
> http://osdir.com/ml/kde-commits/2014-09/msg00859.html
> Was I supposed to forwardport my commits rather than relying on a regular git merge?

Hm, I might have missed that. I usually do the cherry-picking and merging,
but I'm fallible...

>
> PS: please CC me I'm not subscribed.
>
> -- 
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel