Review Request 123952: Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL

Jarosław Staniek staniek at kde.org
Sun May 31 21:57:29 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123952/
-----------------------------------------------------------

(Updated May 31, 2015, 8:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Changes
-------

Submitted with commit 03b43ccbfd65c17362003047e7fec8ecef3c3bb7 by Jaroslaw Staniek to branch calligra/2.9.


Bugs: 348203
    http://bugs.kde.org/show_bug.cgi?id=348203


Repository: calligra


Description
-------

Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL

This fixes the issue "PostgreSQL uses case-sensitive search for LIKE
SQL operator, Kexi's default is case-insensitive"

The approach isn't generic enough for other expressions (the context
of connection could be better) but it's already much better than ignoring
differences between servers.


Diffs
-----

  kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 83f655c56a7d58c6f0aca87786261d0a6571345a 
  kexi/plugins/queries/kexiquerydesignerguieditor.cpp 2943df6bef7a08312ff19deeb2a146f1da0f450b 
  kexi/widget/tableview/kexicomboboxpopup.cpp 1a0e0eca61f881e638242197dc6cbeef8c69200a 
  libs/db/connection.cpp af245efb17345f515cde3b4457f74e59a849077d 
  libs/db/driver.cpp c1277a8993ced0ec7e4019fed990df8d4a0f5d5f 
  libs/db/driver_p.h 4cdfb5bf051ba3888ffe96974eee19e18a22269c 
  libs/db/expression.h a7b0410a6172c7cc662213f540497855a97501ee 
  libs/db/expression.cpp 794732ea12830dfd09aac4cd0c16675e1ab6fedb 
  libs/db/parser/parser_p.cpp 5f11f4ea8ce947bf3e4e9dfd97e5f259776fc90b 

Diff: https://git.reviewboard.kde.org/r/123952/diff/


Testing
-------

Queries work now for pgsql as for sqlite/mysql


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150531/63b959f4/attachment.htm>


More information about the calligra-devel mailing list