Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables

Jarosław Staniek staniek at kde.org
Sat May 30 20:32:22 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123942/
-----------------------------------------------------------

(Updated May 30, 2015, 7:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Changes
-------

Submitted with commit fd3942a3c5228acc224ac3afd4f0a4e83a56c16f by Jaroslaw Staniek to branch calligra/2.9.


Bugs: 330410
    http://bugs.kde.org/show_bug.cgi?id=330410


Repository: calligra


Description
-------

Keep pointer to related Connection object in query, so it can be used to find related tables

To do this, add a QuerySchema ctor and allow to call it internally by the parser.
We had to move QuerySchemaPrivate to separate files.


Diffs
-----

  libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 
  libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 
  libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 
  libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be 
  libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 
  libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 
  libs/db/queryschema_p.h PRE-CREATION 
  libs/db/queryschema_p.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123942/diff/


Testing
-------

Queries work as expected, changes only relate to the conn pointer


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150530/0f2956f3/attachment.htm>


More information about the calligra-devel mailing list