Review Request 123941: Get the example to show data

Jarosław Staniek staniek at kde.org
Fri May 29 23:52:53 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123941/#review80957
-----------------------------------------------------------


Quick note: please use CamelCase for new files i.e. KReportView.h, KReportExampleData.h etc. One day we'll fix all the files (obviously before a stable release), and will remove the o in KoFoo's.

- Jarosław Staniek


On May 30, 2015, 12:49 a.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123941/
> -----------------------------------------------------------
> 
> (Updated May 30, 2015, 12:49 a.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek.
> 
> 
> Repository: kreport
> 
> 
> Description
> -------
> 
> Add class KReportView based on a cut down KexiReportView ... useful to library users
> Add class for example data
> Mod plugin manager to load using old names (buggy)
> PLug it all together
> 
> 
> Diffs
> -----
> 
>   examples/CMakeLists.txt 17835962c87dfeec7b5976d0dff5bfd540fff904 
>   examples/designerwindow.h 95866d24ea871cc85a0853520e829fca22a7bbe2 
>   examples/designerwindow.cpp 6d0ceabe011395efb67a066947863d14d566bf67 
>   examples/kreportexampledata.h PRE-CREATION 
>   examples/kreportexampledata.cpp PRE-CREATION 
>   examples/main.cpp e02759e5820885b146d45c0b17af668a79bf5ae3 
>   examples/window.h 83405f59684bbfe2962725d129b071f7d3c4d1a9 
>   examples/window.cpp 63863eb92faae08fe5830c699b99129503e65447 
>   src/CMakeLists.txt 3928786dcee9072c772d5926264d66053dc81ef7 
>   src/common/KoReportPluginManager.cpp 5746f75437ae11a9f92f8197985c767321d19a5d 
>   src/items/field/KoReportDesignerItemField.cpp bf7bbf0c22462ba0ce58f300720abd3f7e2b871f 
>   src/renderer/KoReportPreRenderer.cpp 86740bb9d1588c1e38ebd05cf06d8843d0e0bdb4 
>   src/renderer/kreportview.h PRE-CREATION 
>   src/renderer/kreportview.cpp PRE-CREATION 
>   src/wrtembed/KoReportDesignerItemLine.cpp 57f20a7ac3099b4ccc216fdf736f87c8d1da2dd8 
> 
> Diff: https://git.reviewboard.kde.org/r/123941/diff/
> 
> 
> Testing
> -------
> 
> http://imgur.com/mseuLA2
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150529/bc5bb2ee/attachment.htm>


More information about the calligra-devel mailing list