macro_optional_find_package -> find_package in 3.0

[Jaroslaw Staniek]

I get the merge argument.

But there are porting scripts for exactly such things already, and
we're going to run them, e.g. the
kde-dev-scripts/kf5/adapt_cmakelists_file.pl one that replaces
kde4_add_library with add_library.

See https://community.kde.org/Kexi/Porting_to_Qt%26KF_5#Porting_scripts_usage_status
for the status

I think using the standard find_package from 2.8.6 wouldn't look like
refactoring but rather would help us to prepare for 3.1, when we
expect our packagers sort out any buildsystem bugs, especially
configure bugs. Also for macosx and windows. Removing custom macros
from "kdelibs4" times looks like preparing to this.


On 22 May 2015 at 23:00, Boudewijn Rempt <boud at valdyas.org> wrote:
> I disagree...
>
> Let's not make any gratuitous string changes that don't fix any functional
> problematical. I'm already running into problems with every merge because
> files got deleted. Any change will cause merge issues and there is exactly
> zero benefit to this change anyway.
>
> Until 3.0 is _done_ we should _not_ do refactoring. We should make it work
> with the least amount of changes.
>
> Boudewijn
>
>
> On Fri, 22 May 2015, Jaroslaw Staniek wrote:
>
>> Hi,
>> I propose to remove usage of macro_optional_find_package() and just
>> using find_package().
>> See
>> https://blogs.kde.org/2011/11/11/cool-new-stuff-cmake-286-3-standard-way-disable-optional-packages
>>
>> --
>> regards, Jaroslaw Staniek
>>
>> KDE:
>> : A world-wide network of software engineers, artists, writers,
>> translators
>> : and facilitators committed to Free Software development - http://kde.org
>> Calligra Suite:
>> : A graphic art and office suite - http://calligra.org
>> Kexi:
>> : A visual database apps builder - http://calligra.org/kexi
>> Qt Certified Specialist:
>> : http://www.linkedin.com/in/jstaniek
>> _______________________________________________
>> calligra-devel mailing list
>> calligra-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/calligra-devel
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek