Review Request 123498: Fixes to KoReport maps plugin

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123498/#review80446
-----------------------------------------------------------



plugins/reporting/maps/KoReportItemMaps.h (line 96)
<https://git.reviewboard.kde.org/r/123498/#comment55175>

    please prepend m_



plugins/reporting/maps/KoReportItemMaps.cpp (line 195)
<https://git.reviewboard.kde.org/r/123498/#comment55176>

    -> realItemData() ?


- Jarosław Staniek


On April 25, 2015, 7:17 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123498/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 7:17 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Tidied up and removed unused function
> Enabled the scripting interface
> Implemented the new maniupulateData interface to allow
> controlling the map widget from a report script
> 
> Requires review 123496
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportItemMaps.h eb8404b8720c084e7cc174c84906c4aadecae396 
>   plugins/reporting/maps/KoReportItemMaps.cpp b23627d356096494d2b6b5c5d64f7dc991f2e7e0 
>   plugins/reporting/maps/KoReportMapsPlugin.cpp 675fd96b6b6c335b946f90611904f1bb20b79a2f 
>   plugins/reporting/maps/krscriptmaps.h 38fba1eade5f025afcf1fc8b586f646f03238456 
>   plugins/reporting/maps/krscriptmaps.cpp 9fc21c7fcb94b888d8bd930fe770af787c6f759b 
> 
> Diff: https://git.reviewboard.kde.org/r/123498/diff/
> 
> 
> Testing
> -------
> 
> Added map to report
> Created script to control map data from individual fields
> Report renders correctly
> 
> 
> File Attachments
> ----------------
> 
> POI Database
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/0012b23c-6396-46e3-8d5c-4d6080338aae__POI.kexi
> What the report should look like
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/02fe1f44-6159-46b4-9998-a401c885bc3a__rptPoi.pdf
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150515/fcb26b16/attachment.htm>