Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

Victor Wåhlström kdebugs at draconic-illusion.com
Wed May 13 04:18:33 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123764/
-----------------------------------------------------------

Review request for Calligra and Boudewijn Rempt.


Bugs: 347541
    http://bugs.kde.org/show_bug.cgi?id=347541


Repository: calligra


Description
-------

This patch limits mouse click interaction with icons to left mouse button.

Note: This fix assumes that context menu events are triggered via right mouse button. This is in theory OS specific, but it looks like other code is already making this assumption.


Diffs
-----

  krita/ui/KisDocumentSectionDelegate.cpp 2efde33 

Diff: https://git.reviewboard.kde.org/r/123764/diff/


Testing
-------

I haven't done extensive testing outside of the layers widget. Worst case it'll disable middle mouse button and right mouse button as alternatives for clicking on icons, which should be fine.

Context menu events are handled elsewhere and still works as expected.


Thanks,

Victor Wåhlström

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150513/b7708cdd/attachment.htm>


More information about the calligra-devel mailing list