Review Request 123651: Kexi: Improvements for reports internal source combobox

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123651/#review80131
-----------------------------------------------------------


Closer to perfect!


kexi/plugins/reports/kexidbreportdata.h (line 37)
<https://git.reviewboard.kde.org/r/123651/#comment54971>

    - Use /*! to make it docs
    - Use @a partClass, @a qstrSQL
    - BTW, I propose to change qstrSQL everywhere to something less cryptic, e.g. objectName
    -



kexi/plugins/reports/kexidbreportdata.h (line 39)
<https://git.reviewboard.kde.org/r/123651/#comment54972>

    Lines 39-41: use "- " prefix so this content will be rendered as a list in docs



kexi/plugins/reports/kexireportpart.cpp (line 46)
<https://git.reviewboard.kde.org/r/123651/#comment54974>

    -> sourceSelector
    -(naming convention: we use human language where possible)



kexi/plugins/reports/kexisourceselector.h (line 39)
<https://git.reviewboard.kde.org/r/123651/#comment54973>

    missing ''explicit'' keyword


- Jarosław Staniek


On May 9, 2015, 1:14 a.m., Kamil Łysik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123651/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 1:14 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 347127
>     http://bugs.kde.org/show_bug.cgi?id=347127
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Kexi: Improvements for reports internal source combobox
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/CMakeLists.txt d563e17 
>   kexi/plugins/reports/InternalSourceSelector.h 384edc2 
>   kexi/plugins/reports/InternalSourceSelector.cpp 1729527 
>   kexi/plugins/reports/kexidbreportdata.h 5a5d367 
>   kexi/plugins/reports/kexidbreportdata.cpp d5cd54e 
>   kexi/plugins/reports/kexireportpart.cpp 88375c6 
>   kexi/plugins/reports/kexisourceselector.h 6dbf91f 
>   kexi/plugins/reports/kexisourceselector.cpp edf02eb 
>   kexi/widget/KexiDataSourceComboBox.cpp 112413b 
> 
> Diff: https://git.reviewboard.kde.org/r/123651/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kamil Łysik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150509/84a77255/attachment.htm>