Review Request 123651: Kexi: Improvements for reports internal source combobox

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123651/#review80109
-----------------------------------------------------------


Thanks!


kexi/plugins/reports/kexidbreportdata.cpp (line 172)
<https://git.reviewboard.kde.org/r/123651/#comment54959>

    getSchema() is not needed in this situation, the code is too similar:
    - use (const QString& partClass = QString()) arg
    - explain what partClass = QString() means and what partClass != QString() means in the docs
    - instead of 
    
    if ( partClass == "org.kexi-project.table" && d->connection->tableSchema ( d->qstrQuery ) )
    
    use:
    
     if ( (partClass.isEmpty() || partClass == "org.kexi-project.table") && d->connection->tableSchema ( d->qstrQuery ) )
     
    - similarly for the line 186



kexi/plugins/reports/kexidbreportdata.cpp (line 174)
<https://git.reviewboard.kde.org/r/123651/#comment54956>

    BTW, fix coding standard everywhere:
    https://techbase.kde.org/Policies/Kdelibs_Coding_Style



kexi/plugins/reports/kexidbreportdata.cpp (line 183)
<https://git.reviewboard.kde.org/r/123651/#comment54957>

    no space needed in debug (" is" -> "is")



kexi/plugins/reports/kexisourceselector.h (line 30)
<https://git.reviewboard.kde.org/r/123651/#comment54961>

    class KexiProject; is enough



kexi/plugins/reports/kexisourceselector.h (line 38)
<https://git.reviewboard.kde.org/r/123651/#comment54962>

    Replace with explicit KexiSourceSelector(KexiProject* project, QWidget* parent = 0);



kexi/widget/KexiDataSourceComboBox.cpp (line 311)
<https://git.reviewboard.kde.org/r/123651/#comment54958>

    'competition' ?



kexi/widget/KexiDataSourceComboBox.cpp (line 312)
<https://git.reviewboard.kde.org/r/123651/#comment54960>

    coding style: always use { }


- Jarosław Staniek


On May 8, 2015, 10:50 p.m., Kamil Łysik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123651/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 10:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 347127
>     http://bugs.kde.org/show_bug.cgi?id=347127
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Kexi: Improvements for reports internal source combobox
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/CMakeLists.txt d563e17 
>   kexi/plugins/reports/InternalSourceSelector.h 384edc2 
>   kexi/plugins/reports/InternalSourceSelector.cpp 1729527 
>   kexi/plugins/reports/kexidbreportdata.h 5a5d367 
>   kexi/plugins/reports/kexidbreportdata.cpp d5cd54e 
>   kexi/plugins/reports/kexireportpart.cpp 88375c6 
>   kexi/plugins/reports/kexisourceselector.h 6dbf91f 
>   kexi/plugins/reports/kexisourceselector.cpp edf02eb 
>   kexi/widget/KexiDataSourceComboBox.cpp 112413b 
> 
> Diff: https://git.reviewboard.kde.org/r/123651/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kamil Łysik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150508/95f95a7f/attachment.htm>