Review Request 123660: Improve KoFindToolbar
Camilla Boemann
cbr at boemann.dk
Wed May 6 15:36:48 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123660/#review79972
-----------------------------------------------------------
Ship it!
Ship It!
- Camilla Boemann
On May 6, 2015, 2:07 p.m., Thorsten Zachmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123660/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 2:07 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> The KoFindToolbar is used in words to search the documents. The current behaviour is a bit stange. When entering a string to search it waits until there is no keypress for 1 sec before it starts to search. This also happens when you press enter. On pressing enter it even goes to the last found string that was seached last.
>
> The patch changes the behaviour to start the search directly after pressing enter without waiting 1 second. If the seach string was not changed enter still goes to the next found match.
>
>
> Diffs
> -----
>
> libs/main/KoFindToolbar.h bbb018f
> libs/main/KoFindToolbar.cpp ca12462
> libs/main/KoFindToolbar_p.h 54ecaf5
>
> Diff: https://git.reviewboard.kde.org/r/123660/diff/
>
>
> Testing
> -------
>
> Tested interactive searching.
>
>
> Thanks,
>
> Thorsten Zachmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150506/209e4faa/attachment.htm>
More information about the calligra-devel
mailing list