Review Request 123623: Use "activated" signal instead of "clicked" in "Welcome" and "New Project" assistants

Jarosław Staniek staniek at kde.org
Mon May 4 21:37:03 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123623/#review79869
-----------------------------------------------------------

Ship it!


Good catch!

- Jarosław Staniek


On May 4, 2015, 10:41 a.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123623/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 10:41 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 346902
>     http://bugs.kde.org/show_bug.cgi?id=346902
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Use ["activated"](http://doc.qt.io/qt-4.8/qabstractitemview.html#activated) signal in listed assistants as it will follow platform-depended UI behavior.
> Originaly was a patch for [346902](https://bugs.kde.org/show_bug.cgi?id=346902)
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiNewProjectAssistant.cpp 20eced7 
>   kexi/main/startup/KexiWelcomeAssistant.cpp 43a36a5 
> 
> Diff: https://git.reviewboard.kde.org/r/123623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150504/c971e6c4/attachment.htm>


More information about the calligra-devel mailing list