Review Request 123587: Addition of user scripting API docs

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123587/#review79866
-----------------------------------------------------------



libs/koreport/renderer/scripting/krscriptconstants.h (line 57)
<https://git.reviewboard.kde.org/r/123587/#comment54717>

    Returns -> @return
    (can be fixed using search/replace)



libs/koreport/renderer/scripting/krscriptconstants.h (line 58)
<https://git.reviewboard.kde.org/r/123587/#comment54718>

    Could you remind what was the reason to use capital letter for PageNumber?



libs/koreport/renderer/scripting/krscriptreport.h (line 57)
<https://git.reviewboard.kde.org/r/123587/#comment54716>

    space after '//!'
    
    (please add everywhere)
    (can be fixed using search/replace)



libs/koreport/renderer/scripting/krscriptsection.h (line 64)
<https://git.reviewboard.kde.org/r/123587/#comment54719>

    add const



libs/koreport/renderer/scripting/krscriptsection.h (line 70)
<https://git.reviewboard.kde.org/r/123587/#comment54720>

    add const



libs/koreport/renderer/scripting/krscriptsection.h (line 76)
<https://git.reviewboard.kde.org/r/123587/#comment54721>

    add const?


- Jarosław Staniek


On May 2, 2015, 11:12 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123587/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 11:12 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Initial documentation for the KoReport user scripting system
> A mainpage with a general overview
> Documentation for the Report object API
> All other docs auto generated
> 
> 
> Diffs
> -----
> 
>   libs/koreport/Doxyfile PRE-CREATION 
>   libs/koreport/KoReportScript.dox PRE-CREATION 
>   libs/koreport/Mainpage.dox 98de42fe1b197679f74b61f5b27c4c552102cd13 
>   libs/koreport/items/label/krscriptlabel.h ade236cb24f45e826b2975a2859f1c2b6060a38b 
>   libs/koreport/renderer/scripting/krscriptconstants.h f90798d2642b87ec9a51a79a863d7128e1664901 
>   libs/koreport/renderer/scripting/krscriptdebug.h e60eac49a61faa2b4baa9b5a0ed607ecac6f62f9 
>   libs/koreport/renderer/scripting/krscriptdraw.h 6fcc886539e540bba86be7e1811ee8f4fc7f7bdf 
>   libs/koreport/renderer/scripting/krscriptreport.h 3b69e2f0a8e362dd1f940714c2c7d00d92b7438b 
>   libs/koreport/renderer/scripting/krscriptsection.h 32fc1a9cf3679664f7062df999b8e7a7f5d425cd 
> 
> Diff: https://git.reviewboard.kde.org/r/123587/diff/
> 
> 
> Testing
> -------
> 
> No code changes
> 
> 
> File Attachments
> ----------------
> 
> Mainpage
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/01/c3b7b571-5fa4-46e2-ac93-470ace2e3b29__scripting.png
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150504/f6b88f1c/attachment.htm>