Review Request 123511: Move KoXmlVector into separate file and add unit tests

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123511/
-----------------------------------------------------------

(Updated May 1, 2015, 2:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Changes
-------

Submitted with commit c280bc7de48831a317f6568c28e6ea3de31674b7 by Friedrich W. H. Kossebau to branch calligra/2.9.


Repository: calligra


Description
-------

While investigating the KoLZF compress/decompress methods and what data actually is processed there, I also had to grasp what KoXmlVector is doing. To help myself I wrote some unit tests for it (for which I needed to move the class into an own file).
Given they exist now, proposing to add those unit tests to the Calligra repo, including a little bit more documentation, so they might help protecting against any future regressions (e.g. during the Qt5/KF5 port) :)


Diffs
-----

  libs/odf/KoXmlReader.cpp 75b1114 
  libs/odf/KoXmlVector.h PRE-CREATION 
  libs/odf/tests/CMakeLists.txt 689bfe4 
  libs/odf/tests/TestKoXmlVector.h PRE-CREATION 
  libs/odf/tests/TestKoXmlVector.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123511/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150501/886dd74b/attachment.htm>