Review Request 123195: fix various bugs related to footnotes

[Camilla Boemann]

> On March 31, 2015, 8:57 p.m., Inge Wallin wrote:
> > libs/kotext/styles/KoStyleManager.cpp, line 154
> > <https://git.reviewboard.kde.org/r/123195/diff/1/?file=359641#file359641line154>
> >
> >     Shouldn't there be some 'if ()'s around these that check if there already are default styles for footnotes etc? And regarding the anchors, shouldn't they be superscript by default?
> 
> Camilla Boemann wrote:
>     for anchors i've just done like LO
>     and well i guess you are right about the first point

at construtor time there can be no other styles, and if loaded later on they will replace these


> On March 31, 2015, 8:57 p.m., Inge Wallin wrote:
> > libs/kotext/KoInlineNote.cpp, line 98
> > <https://git.reviewboard.kde.org/r/123195/diff/1/?file=359639#file359639line98>
> >
> >     What's the fallback if the style returned is 0? And under which circumstances can that happen?
> 
> Camilla Boemann wrote:
>     good catch - none i guess

I guess it would mean the user is loading an invalid file that refers to styles that are not in the file. I am not sure what we could do about this, because then what should we use instead ?


- Camilla


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123195/#review78299
-----------------------------------------------------------


On March 31, 2015, 11:25 a.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123195/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 11:25 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The footnotes and endnotes were not displayed using the correct styles. We had just hard coded them to be shown using
>     superscript, but they should be done using the styles specified by the notes configuration.
>     
>     The same applies to the paragraph style of the note itself - but since this is just a default we didn't see any problem
>     when loading files, only when adding our own footnotes.
>     
>     Now netiher of the 3 styles specified by the notes configuraion needs to be present in files, and indeed are not present in
>     our templates, so what LO does is add some styles. We do the same with these 6 styles
>     
>     Footnote : based on default paragraph
>     Footnote Symbol : Applied to the id in the footnote itself - just a black text style
>     Footnote anchor : Applied to the id in the main text area - superscript
>     Endnote : based on default paragraph
>     Endnote Symbol : Applied to the id in the endnote itself - just a black text style
>     Endnote anchor : Applied to the id in the main text area - superscript
>     
>     BUG:306141
>     BUG:323232
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.cpp ec8f4d0 
>   libs/kotext/opendocument/KoTextSharedLoadingData.cpp 600ad37 
>   libs/kotext/styles/KoStyleManager.cpp dc8bdfd 
>   libs/odf/KoOdfNotesConfiguration.h 6395185 
>   libs/odf/KoOdfNotesConfiguration.cpp ae6d8ac 
>   libs/odf/KoOdfNumberDefinition.cpp 5670f9f 
>   libs/odf/KoOdfStylesReader.cpp 2c0f5b2 
>   libs/textlayout/KoTextLayoutNoteArea.cpp 0d1497d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp 96aae3c 
> 
> Diff: https://git.reviewboard.kde.org/r/123195/diff/
> 
> 
> Testing
> -------
> 
> only manual testing
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150331/185a1287/attachment.htm>